change history to clean

This commit is contained in:
Julian Freeman
2026-04-17 13:44:41 -04:00
parent b9f24e07cf
commit 6d2b117200
11 changed files with 696 additions and 351 deletions

View File

@@ -1,8 +1,15 @@
use std::{path::PathBuf, process::Command}; use std::{
fs,
path::{Path, PathBuf},
process::Command,
};
use crate::{ use crate::{
config_store, config_store,
models::{BrowserConfigListResponse, CreateCustomBrowserConfigInput, ScanResponse}, models::{
BrowserConfigListResponse, CleanupHistoryInput, CleanupHistoryResponse,
CleanupHistoryResult, CreateCustomBrowserConfigInput, ScanResponse,
},
scanner, scanner,
}; };
use tauri::AppHandle; use tauri::AppHandle;
@@ -61,6 +68,31 @@ pub fn open_browser_profile(
spawn_browser_process(executable_path, user_data_dir, profile_id) spawn_browser_process(executable_path, user_data_dir, profile_id)
} }
#[tauri::command]
pub fn cleanup_history_files(
app: AppHandle,
input: CleanupHistoryInput,
) -> Result<CleanupHistoryResponse, String> {
let config = config_store::find_browser_config(&app, &input.browser_id)?;
let user_data_dir = PathBuf::from(&config.user_data_path);
if !user_data_dir.is_dir() {
return Err(format!(
"User data directory does not exist: {}",
user_data_dir.display()
));
}
let mut results = Vec::new();
for profile_id in input.profile_ids {
let profile_path = user_data_dir.join(&profile_id);
let result = cleanup_profile_history_files(&profile_path, &profile_id);
results.push(result);
}
Ok(CleanupHistoryResponse { results })
}
fn spawn_browser_process( fn spawn_browser_process(
executable_path: PathBuf, executable_path: PathBuf,
user_data_dir: PathBuf, user_data_dir: PathBuf,
@@ -79,3 +111,56 @@ fn spawn_browser_process(
) )
}) })
} }
fn cleanup_profile_history_files(profile_path: &Path, profile_id: &str) -> CleanupHistoryResult {
if !profile_path.is_dir() {
return CleanupHistoryResult {
profile_id: profile_id.to_string(),
deleted_files: Vec::new(),
skipped_files: Vec::new(),
error: Some(format!(
"Profile directory does not exist: {}",
profile_path.display()
)),
};
}
let mut deleted_files = Vec::new();
let mut skipped_files = Vec::new();
for file_name in ["History", "Top Sites", "Visited Links"] {
let file_path = profile_path.join(file_name);
if !file_path.exists() {
skipped_files.push(file_name.to_string());
continue;
}
if let Err(error) = fs::remove_file(&file_path) {
return CleanupHistoryResult {
profile_id: profile_id.to_string(),
deleted_files,
skipped_files,
error: Some(format!("Failed to delete {}: {error}", file_path.display())),
};
}
deleted_files.push(file_name.to_string());
remove_sidecar_files(&file_path);
}
CleanupHistoryResult {
profile_id: profile_id.to_string(),
deleted_files,
skipped_files,
error: None,
}
}
fn remove_sidecar_files(path: &Path) {
for suffix in ["-journal", "-wal", "-shm"] {
let sidecar = PathBuf::from(format!("{}{}", path.display(), suffix));
if sidecar.is_file() {
let _ = fs::remove_file(sidecar);
}
}
}

View File

@@ -15,7 +15,8 @@ pub fn run() {
commands::list_browser_configs, commands::list_browser_configs,
commands::create_custom_browser_config, commands::create_custom_browser_config,
commands::delete_custom_browser_config, commands::delete_custom_browser_config,
commands::open_browser_profile commands::open_browser_profile,
commands::cleanup_history_files
]) ])
.run(tauri::generate_context!()) .run(tauri::generate_context!())
.expect("error while running tauri application"); .expect("error while running tauri application");

View File

@@ -20,7 +20,6 @@ pub struct BrowserView {
pub extensions: Vec<ExtensionSummary>, pub extensions: Vec<ExtensionSummary>,
pub bookmarks: Vec<BookmarkSummary>, pub bookmarks: Vec<BookmarkSummary>,
pub password_sites: Vec<PasswordSiteSummary>, pub password_sites: Vec<PasswordSiteSummary>,
pub history_domains: Vec<HistoryDomainSummary>,
pub stats: BrowserStats, pub stats: BrowserStats,
} }
@@ -31,7 +30,7 @@ pub struct BrowserStats {
pub extension_count: usize, pub extension_count: usize,
pub bookmark_count: usize, pub bookmark_count: usize,
pub password_site_count: usize, pub password_site_count: usize,
pub history_domain_count: usize, pub history_cleanup_profile_count: usize,
} }
#[derive(Serialize)] #[derive(Serialize)]
@@ -46,6 +45,7 @@ pub struct ProfileSummary {
pub default_avatar_stroke_color: Option<i64>, pub default_avatar_stroke_color: Option<i64>,
pub avatar_label: String, pub avatar_label: String,
pub path: String, pub path: String,
pub history_cleanup: HistoryCleanupSummary,
} }
#[derive(Serialize)] #[derive(Serialize)]
@@ -77,13 +77,41 @@ pub struct PasswordSiteSummary {
pub profiles: Vec<AssociatedProfileSummary>, pub profiles: Vec<AssociatedProfileSummary>,
} }
#[derive(Serialize, Clone)]
#[serde(rename_all = "camelCase")]
pub struct HistoryCleanupSummary {
pub history: CleanupFileStatus,
pub top_sites: CleanupFileStatus,
pub visited_links: CleanupFileStatus,
}
#[derive(Serialize, Deserialize, Clone, Copy, PartialEq, Eq)]
#[serde(rename_all = "camelCase")]
pub enum CleanupFileStatus {
Found,
Missing,
}
#[derive(Serialize, Deserialize)]
#[serde(rename_all = "camelCase")]
pub struct CleanupHistoryInput {
pub browser_id: String,
pub profile_ids: Vec<String>,
}
#[derive(Serialize)] #[derive(Serialize)]
#[serde(rename_all = "camelCase")] #[serde(rename_all = "camelCase")]
pub struct HistoryDomainSummary { pub struct CleanupHistoryResponse {
pub domain: String, pub results: Vec<CleanupHistoryResult>,
pub visit_count: i64, }
pub profile_ids: Vec<String>,
pub profiles: Vec<AssociatedProfileSummary>, #[derive(Serialize)]
#[serde(rename_all = "camelCase")]
pub struct CleanupHistoryResult {
pub profile_id: String,
pub deleted_files: Vec<String>,
pub skipped_files: Vec<String>,
pub error: Option<String>,
} }
#[derive(Serialize, Clone)] #[derive(Serialize, Clone)]
@@ -194,10 +222,3 @@ pub struct TempPasswordSite {
pub profile_ids: BTreeSet<String>, pub profile_ids: BTreeSet<String>,
pub profiles: BTreeMap<String, AssociatedProfileSummary>, pub profiles: BTreeMap<String, AssociatedProfileSummary>,
} }
pub struct TempHistoryDomain {
pub domain: String,
pub visit_count: i64,
pub profile_ids: BTreeSet<String>,
pub profiles: BTreeMap<String, AssociatedProfileSummary>,
}

View File

@@ -11,9 +11,9 @@ use crate::{
config_store, config_store,
models::{ models::{
AssociatedProfileSummary, BookmarkAssociatedProfileSummary, BookmarkSummary, AssociatedProfileSummary, BookmarkAssociatedProfileSummary, BookmarkSummary,
BrowserConfigEntry, BrowserStats, BrowserView, ExtensionSummary, HistoryDomainSummary, BrowserConfigEntry, BrowserStats, BrowserView, CleanupFileStatus, ExtensionSummary,
PasswordSiteSummary, ProfileSummary, ScanResponse, TempBookmark, TempExtension, HistoryCleanupSummary, PasswordSiteSummary, ProfileSummary, ScanResponse, TempBookmark,
TempHistoryDomain, TempPasswordSite, TempExtension, TempPasswordSite,
}, },
utils::{ utils::{
copy_sqlite_database_to_temp, first_non_empty, load_image_as_data_url, read_json_file, copy_sqlite_database_to_temp, first_non_empty, load_image_as_data_url, read_json_file,
@@ -48,7 +48,6 @@ fn scan_browser(config: BrowserConfigEntry) -> Option<BrowserView> {
let mut extensions = BTreeMap::<String, TempExtension>::new(); let mut extensions = BTreeMap::<String, TempExtension>::new();
let mut bookmarks = BTreeMap::<String, TempBookmark>::new(); let mut bookmarks = BTreeMap::<String, TempBookmark>::new();
let mut password_sites = BTreeMap::<String, TempPasswordSite>::new(); let mut password_sites = BTreeMap::<String, TempPasswordSite>::new();
let mut history_domains = BTreeMap::<String, TempHistoryDomain>::new();
for profile_id in profile_ids { for profile_id in profile_ids {
let profile_path = root.join(&profile_id); let profile_path = root.join(&profile_id);
@@ -62,7 +61,6 @@ fn scan_browser(config: BrowserConfigEntry) -> Option<BrowserView> {
scan_extensions_for_profile(&profile_path, &profile_summary, &mut extensions); scan_extensions_for_profile(&profile_path, &profile_summary, &mut extensions);
scan_bookmarks_for_profile(&profile_path, &profile_summary, &mut bookmarks); scan_bookmarks_for_profile(&profile_path, &profile_summary, &mut bookmarks);
scan_password_sites_for_profile(&profile_path, &profile_summary, &mut password_sites); scan_password_sites_for_profile(&profile_path, &profile_summary, &mut password_sites);
scan_history_domains_for_profile(&profile_path, &profile_summary, &mut history_domains);
profiles.push(profile_summary); profiles.push(profile_summary);
} }
@@ -96,15 +94,15 @@ fn scan_browser(config: BrowserConfigEntry) -> Option<BrowserView> {
profiles: entry.profiles.into_values().collect(), profiles: entry.profiles.into_values().collect(),
}) })
.collect::<Vec<_>>(); .collect::<Vec<_>>();
let history_domains = history_domains let history_cleanup_profile_count = profiles
.into_values() .iter()
.map(|entry| HistoryDomainSummary { .filter(|profile| {
domain: entry.domain, let cleanup = &profile.history_cleanup;
visit_count: entry.visit_count, cleanup.history == CleanupFileStatus::Found
profile_ids: entry.profile_ids.into_iter().collect(), || cleanup.top_sites == CleanupFileStatus::Found
profiles: entry.profiles.into_values().collect(), || cleanup.visited_links == CleanupFileStatus::Found
}) })
.collect::<Vec<_>>(); .count();
Some(BrowserView { Some(BrowserView {
browser_id: config.id, browser_id: config.id,
@@ -117,13 +115,12 @@ fn scan_browser(config: BrowserConfigEntry) -> Option<BrowserView> {
extension_count: extensions.len(), extension_count: extensions.len(),
bookmark_count: bookmarks.len(), bookmark_count: bookmarks.len(),
password_site_count: password_sites.len(), password_site_count: password_sites.len(),
history_domain_count: history_domains.len(), history_cleanup_profile_count,
}, },
profiles, profiles,
extensions: sort_extensions(extensions), extensions: sort_extensions(extensions),
bookmarks: sort_bookmarks(bookmarks), bookmarks: sort_bookmarks(bookmarks),
password_sites: sort_password_sites(password_sites), password_sites: sort_password_sites(password_sites),
history_domains: sort_history_domains(history_domains),
}) })
} }
@@ -189,6 +186,23 @@ fn build_profile_summary(
default_avatar_stroke_color, default_avatar_stroke_color,
avatar_label, avatar_label,
path: profile_path.display().to_string(), path: profile_path.display().to_string(),
history_cleanup: scan_history_cleanup_status(profile_path),
}
}
fn scan_history_cleanup_status(profile_path: &Path) -> HistoryCleanupSummary {
HistoryCleanupSummary {
history: cleanup_file_status(&profile_path.join("History")),
top_sites: cleanup_file_status(&profile_path.join("Top Sites")),
visited_links: cleanup_file_status(&profile_path.join("Visited Links")),
}
}
fn cleanup_file_status(path: &Path) -> CleanupFileStatus {
if path.is_file() {
CleanupFileStatus::Found
} else {
CleanupFileStatus::Missing
} }
} }
@@ -623,71 +637,6 @@ fn scan_password_sites_for_profile(
} }
} }
fn scan_history_domains_for_profile(
profile_path: &Path,
profile: &ProfileSummary,
history_domains: &mut BTreeMap<String, TempHistoryDomain>,
) {
let history_path = profile_path.join("History");
if !history_path.is_file() {
return;
}
let Some(temp_copy) = copy_sqlite_database_to_temp(&history_path) else {
return;
};
let Ok(connection) = Connection::open_with_flags(
temp_copy.path(),
OpenFlags::SQLITE_OPEN_READ_ONLY | OpenFlags::SQLITE_OPEN_NO_MUTEX,
) else {
return;
};
let Ok(mut statement) = connection
.prepare("SELECT url, visit_count FROM urls WHERE hidden = 0 AND visit_count > 0")
else {
return;
};
let Ok(rows) = statement.query_map([], |row| {
Ok((row.get::<_, Option<String>>(0)?, row.get::<_, i64>(1)?))
}) else {
return;
};
for row in rows.flatten() {
let Some(url) = row.0.as_deref() else {
continue;
};
let Some(domain) = domain_from_url(url) else {
continue;
};
let entry = history_domains
.entry(domain.clone())
.or_insert_with(|| TempHistoryDomain {
domain: domain.clone(),
visit_count: 0,
profile_ids: BTreeSet::new(),
profiles: BTreeMap::new(),
});
entry.visit_count += row.1.max(0);
entry.profile_ids.insert(profile.id.clone());
entry
.profiles
.entry(profile.id.clone())
.or_insert_with(|| AssociatedProfileSummary {
id: profile.id.clone(),
name: profile.name.clone(),
avatar_data_url: profile.avatar_data_url.clone(),
avatar_icon: profile.avatar_icon.clone(),
default_avatar_fill_color: profile.default_avatar_fill_color,
default_avatar_stroke_color: profile.default_avatar_stroke_color,
avatar_label: profile.avatar_label.clone(),
});
}
}
fn normalize_login_site(origin_url: Option<&str>, signon_realm: Option<&str>) -> Option<String> { fn normalize_login_site(origin_url: Option<&str>, signon_realm: Option<&str>) -> Option<String> {
let candidate = [signon_realm, origin_url] let candidate = [signon_realm, origin_url]
.into_iter() .into_iter()
@@ -719,16 +668,3 @@ fn sort_password_sites(mut password_sites: Vec<PasswordSiteSummary>) -> Vec<Pass
}); });
password_sites password_sites
} }
fn sort_history_domains(
mut history_domains: Vec<HistoryDomainSummary>,
) -> Vec<HistoryDomainSummary> {
history_domains.sort_by(|left, right| {
right
.visit_count
.cmp(&left.visit_count)
.then_with(|| left.domain.to_lowercase().cmp(&right.domain.to_lowercase()))
.then_with(|| left.domain.cmp(&right.domain))
});
history_domains
}

View File

@@ -16,13 +16,17 @@ const {
configsLoading, configsLoading,
createConfigForm, createConfigForm,
createCustomBrowserConfig, createCustomBrowserConfig,
cleanupHistoryError,
cleanupHistoryForProfile,
cleanupHistoryResults,
cleanupHistorySelectedProfiles,
cleanupSelectedHistoryProfiles,
currentBrowser, currentBrowser,
deleteCustomBrowserConfig, deleteCustomBrowserConfig,
domainFromUrl,
error, error,
extensionMonogram, extensionMonogram,
extensionSortKey, extensionSortKey,
historyDomainSortKey, historyCleanupBusy,
isDeletingConfig, isDeletingConfig,
isOpeningProfile, isOpeningProfile,
loading, loading,
@@ -39,13 +43,13 @@ const {
selectedBrowserId, selectedBrowserId,
showBookmarkProfilesModal, showBookmarkProfilesModal,
showExtensionProfilesModal, showExtensionProfilesModal,
showHistoryDomainProfilesModal,
showPasswordSiteProfilesModal, showPasswordSiteProfilesModal,
sortedBookmarks, sortedBookmarks,
sortedExtensions, sortedExtensions,
sortedHistoryDomains,
sortedPasswordSites, sortedPasswordSites,
sortedProfiles, sortedProfiles,
toggleAllHistoryProfiles,
toggleHistoryProfile,
closeAssociatedProfilesModal, closeAssociatedProfilesModal,
} = useBrowserManager(); } = useBrowserManager();
</script> </script>
@@ -109,29 +113,32 @@ const {
:extension-sort-key="extensionSortKey" :extension-sort-key="extensionSortKey"
:bookmark-sort-key="bookmarkSortKey" :bookmark-sort-key="bookmarkSortKey"
:password-site-sort-key="passwordSiteSortKey" :password-site-sort-key="passwordSiteSortKey"
:history-domain-sort-key="historyDomainSortKey"
:sorted-profiles="sortedProfiles" :sorted-profiles="sortedProfiles"
:sorted-extensions="sortedExtensions" :sorted-extensions="sortedExtensions"
:sorted-bookmarks="sortedBookmarks" :sorted-bookmarks="sortedBookmarks"
:sorted-password-sites="sortedPasswordSites" :sorted-password-sites="sortedPasswordSites"
:sorted-history-domains="sortedHistoryDomains" :history-selected-profile-ids="cleanupHistorySelectedProfiles"
:cleanup-history-busy="historyCleanupBusy"
:cleanup-history-error="cleanupHistoryError"
:cleanup-history-results="cleanupHistoryResults"
:open-profile-error="openProfileError" :open-profile-error="openProfileError"
:section-count="sectionCount" :section-count="sectionCount"
:is-opening-profile="isOpeningProfile" :is-opening-profile="isOpeningProfile"
:extension-monogram="extensionMonogram" :extension-monogram="extensionMonogram"
:domain-from-url="domainFromUrl"
:associated-profiles-modal="associatedProfilesModal" :associated-profiles-modal="associatedProfilesModal"
@update:active-section="activeSection = $event" @update:active-section="activeSection = $event"
@update:profile-sort-key="profileSortKey = $event" @update:profile-sort-key="profileSortKey = $event"
@update:extension-sort-key="extensionSortKey = $event" @update:extension-sort-key="extensionSortKey = $event"
@update:bookmark-sort-key="bookmarkSortKey = $event" @update:bookmark-sort-key="bookmarkSortKey = $event"
@update:password-site-sort-key="passwordSiteSortKey = $event" @update:password-site-sort-key="passwordSiteSortKey = $event"
@update:history-domain-sort-key="historyDomainSortKey = $event"
@open-profile="(browserId, profileId) => openBrowserProfile(browserId, profileId)" @open-profile="(browserId, profileId) => openBrowserProfile(browserId, profileId)"
@show-extension-profiles="showExtensionProfilesModal" @show-extension-profiles="showExtensionProfilesModal"
@show-bookmark-profiles="showBookmarkProfilesModal" @show-bookmark-profiles="showBookmarkProfilesModal"
@show-password-site-profiles="showPasswordSiteProfilesModal" @show-password-site-profiles="showPasswordSiteProfilesModal"
@show-history-domain-profiles="showHistoryDomainProfilesModal" @toggle-history-profile="toggleHistoryProfile"
@toggle-all-history-profiles="toggleAllHistoryProfiles"
@cleanup-selected-history="cleanupSelectedHistoryProfiles"
@cleanup-history-for-profile="cleanupHistoryForProfile"
@close-associated-profiles="closeAssociatedProfilesModal" @close-associated-profiles="closeAssociatedProfilesModal"
/> />

View File

@@ -6,14 +6,14 @@ import type {
BookmarkSortKey, BookmarkSortKey,
BrowserView, BrowserView,
ExtensionSortKey, ExtensionSortKey,
HistoryDomainSortKey, CleanupHistoryResult,
PasswordSiteSortKey, PasswordSiteSortKey,
ProfileSortKey, ProfileSortKey,
} from "../../types/browser"; } from "../../types/browser";
import AssociatedProfilesModal from "./AssociatedProfilesModal.vue"; import AssociatedProfilesModal from "./AssociatedProfilesModal.vue";
import BookmarksList from "./BookmarksList.vue"; import BookmarksList from "./BookmarksList.vue";
import ExtensionsList from "./ExtensionsList.vue"; import ExtensionsList from "./ExtensionsList.vue";
import HistoryDomainsList from "./HistoryDomainsList.vue"; import HistoryCleanupList from "./HistoryCleanupList.vue";
import PasswordSitesList from "./PasswordSitesList.vue"; import PasswordSitesList from "./PasswordSitesList.vue";
import ProfilesList from "./ProfilesList.vue"; import ProfilesList from "./ProfilesList.vue";
@@ -24,17 +24,18 @@ defineProps<{
extensionSortKey: ExtensionSortKey; extensionSortKey: ExtensionSortKey;
bookmarkSortKey: BookmarkSortKey; bookmarkSortKey: BookmarkSortKey;
passwordSiteSortKey: PasswordSiteSortKey; passwordSiteSortKey: PasswordSiteSortKey;
historyDomainSortKey: HistoryDomainSortKey;
sortedProfiles: BrowserView["profiles"]; sortedProfiles: BrowserView["profiles"];
sortedExtensions: BrowserView["extensions"]; sortedExtensions: BrowserView["extensions"];
sortedBookmarks: BrowserView["bookmarks"]; sortedBookmarks: BrowserView["bookmarks"];
sortedPasswordSites: BrowserView["passwordSites"]; sortedPasswordSites: BrowserView["passwordSites"];
sortedHistoryDomains: BrowserView["historyDomains"]; historySelectedProfileIds: string[];
cleanupHistoryBusy: boolean;
cleanupHistoryError: string;
cleanupHistoryResults: CleanupHistoryResult[];
openProfileError: string; openProfileError: string;
sectionCount: (section: ActiveSection) => number; sectionCount: (section: ActiveSection) => number;
isOpeningProfile: (browserId: string, profileId: string) => boolean; isOpeningProfile: (browserId: string, profileId: string) => boolean;
extensionMonogram: (name: string) => string; extensionMonogram: (name: string) => string;
domainFromUrl: (url: string) => string;
associatedProfilesModal: { associatedProfilesModal: {
title: string; title: string;
browserId: string; browserId: string;
@@ -49,12 +50,14 @@ const emit = defineEmits<{
"update:extensionSortKey": [value: ExtensionSortKey]; "update:extensionSortKey": [value: ExtensionSortKey];
"update:bookmarkSortKey": [value: BookmarkSortKey]; "update:bookmarkSortKey": [value: BookmarkSortKey];
"update:passwordSiteSortKey": [value: PasswordSiteSortKey]; "update:passwordSiteSortKey": [value: PasswordSiteSortKey];
"update:historyDomainSortKey": [value: HistoryDomainSortKey];
openProfile: [browserId: string, profileId: string]; openProfile: [browserId: string, profileId: string];
showExtensionProfiles: [extensionId: string]; showExtensionProfiles: [extensionId: string];
showBookmarkProfiles: [url: string]; showBookmarkProfiles: [url: string];
showPasswordSiteProfiles: [url: string]; showPasswordSiteProfiles: [url: string];
showHistoryDomainProfiles: [domain: string]; toggleHistoryProfile: [profileId: string];
toggleAllHistoryProfiles: [];
cleanupSelectedHistory: [];
cleanupHistoryForProfile: [profileId: string];
closeAssociatedProfiles: []; closeAssociatedProfiles: [];
}>(); }>();
</script> </script>
@@ -146,12 +149,19 @@ const emit = defineEmits<{
@show-profiles="emit('showPasswordSiteProfiles', $event)" @show-profiles="emit('showPasswordSiteProfiles', $event)"
/> />
<HistoryDomainsList <HistoryCleanupList
v-else v-else
:history-domains="sortedHistoryDomains" :browser-id="currentBrowser.browserId"
:sort-key="historyDomainSortKey" :browser-family-id="currentBrowser.browserFamilyId"
@update:sort-key="emit('update:historyDomainSortKey', $event)" :profiles="sortedProfiles"
@show-profiles="emit('showHistoryDomainProfiles', $event)" :selected-profile-ids="historySelectedProfileIds"
:cleanup-busy="cleanupHistoryBusy"
:cleanup-error="cleanupHistoryError"
:cleanup-results="cleanupHistoryResults"
@toggle-profile="emit('toggleHistoryProfile', $event)"
@toggle-all-profiles="emit('toggleAllHistoryProfiles')"
@cleanup-selected="emit('cleanupSelectedHistory')"
@cleanup-profile="emit('cleanupHistoryForProfile', $event)"
/> />
</div> </div>

View File

@@ -0,0 +1,391 @@
<script setup lang="ts">
import { computed } from "vue";
import type {
CleanupHistoryResult,
CleanupFileStatus,
ProfileSummary,
} from "../../types/browser";
import { profileAvatarSrc } from "../../utils/icons";
const props = defineProps<{
browserId: string;
browserFamilyId: string | null;
profiles: ProfileSummary[];
selectedProfileIds: string[];
cleanupBusy: boolean;
cleanupError: string;
cleanupResults: CleanupHistoryResult[];
}>();
const emit = defineEmits<{
toggleProfile: [profileId: string];
toggleAllProfiles: [];
cleanupSelected: [];
cleanupProfile: [profileId: string];
}>();
const selectableProfiles = computed(() =>
props.profiles.filter((profile) =>
hasAnyHistoryFile([
profile.historyCleanup.history,
profile.historyCleanup.topSites,
profile.historyCleanup.visitedLinks,
]),
),
);
const allSelected = computed(
() =>
selectableProfiles.value.length > 0 &&
selectableProfiles.value.every((profile) =>
props.selectedProfileIds.includes(profile.id),
),
);
function statusLabel(status: CleanupFileStatus) {
return status === "found" ? "Found" : "Missing";
}
function statusClass(status: CleanupFileStatus) {
return status === "found" ? "found" : "missing";
}
function isSelected(profileId: string) {
return props.selectedProfileIds.includes(profileId);
}
function isSelectable(profile: ProfileSummary) {
return hasAnyHistoryFile([
profile.historyCleanup.history,
profile.historyCleanup.topSites,
profile.historyCleanup.visitedLinks,
]);
}
function hasAnyHistoryFile(statuses: CleanupFileStatus[]) {
return statuses.some((status) => status === "found");
}
</script>
<template>
<section class="table-section">
<div v-if="cleanupError" class="inline-error">
{{ cleanupError }}
</div>
<div v-if="cleanupResults.length" class="result-strip">
<article
v-for="result in cleanupResults"
:key="result.profileId"
class="result-chip"
:class="{ error: result.error }"
>
<strong>{{ result.profileId }}</strong>
<span v-if="result.error">{{ result.error }}</span>
<span v-else-if="result.deletedFiles.length">
Deleted {{ result.deletedFiles.join(", ") }}
</span>
<span v-else>
Nothing to delete
</span>
</article>
</div>
<div class="history-toolbar">
<label class="toolbar-checkbox" :class="{ disabled: !selectableProfiles.length }">
<input
type="checkbox"
:checked="allSelected"
:disabled="!selectableProfiles.length || cleanupBusy"
@change="emit('toggleAllProfiles')"
/>
<span>Select All</span>
</label>
<button
class="danger-button"
type="button"
:disabled="!selectedProfileIds.length || cleanupBusy"
@click="emit('cleanupSelected')"
>
{{ cleanupBusy ? "Cleaning..." : `Clean Selected (${selectedProfileIds.length})` }}
</button>
</div>
<div v-if="profiles.length" class="data-table">
<div class="data-table-header history-grid">
<div class="header-cell checkbox-cell">Pick</div>
<div class="header-cell icon-cell">Avatar</div>
<div class="header-cell">Profile</div>
<div class="header-cell">History</div>
<div class="header-cell">Top Sites</div>
<div class="header-cell">Visited Links</div>
<div class="header-cell actions-cell">Action</div>
</div>
<div class="data-table-body styled-scrollbar">
<article v-for="profile in profiles" :key="profile.id" class="data-table-row history-grid">
<div class="row-cell checkbox-cell">
<input
type="checkbox"
:checked="isSelected(profile.id)"
:disabled="!isSelectable(profile) || cleanupBusy"
@change="emit('toggleProfile', profile.id)"
/>
</div>
<div class="profile-avatar table-avatar">
<img
v-if="profileAvatarSrc(profile, browserFamilyId)"
:src="profileAvatarSrc(profile, browserFamilyId) ?? undefined"
:alt="`${profile.name} avatar`"
/>
<span v-else>{{ profile.avatarLabel }}</span>
</div>
<div class="row-cell primary-cell">
<strong>{{ profile.name }}</strong>
<span class="subtle-line">{{ profile.id }}</span>
</div>
<div class="row-cell">
<span class="status-pill" :class="statusClass(profile.historyCleanup.history)">
{{ statusLabel(profile.historyCleanup.history) }}
</span>
</div>
<div class="row-cell">
<span class="status-pill" :class="statusClass(profile.historyCleanup.topSites)">
{{ statusLabel(profile.historyCleanup.topSites) }}
</span>
</div>
<div class="row-cell">
<span class="status-pill" :class="statusClass(profile.historyCleanup.visitedLinks)">
{{ statusLabel(profile.historyCleanup.visitedLinks) }}
</span>
</div>
<div class="row-cell actions-cell">
<button
class="danger-button action-button"
type="button"
:disabled="!isSelectable(profile) || cleanupBusy"
@click="emit('cleanupProfile', profile.id)"
>
Clean
</button>
</div>
</article>
</div>
</div>
<div v-else class="empty-card">
<p>No profile directories were found for this browser.</p>
</div>
</section>
</template>
<style scoped>
.table-section {
display: flex;
flex-direction: column;
gap: 10px;
padding: 0;
height: 100%;
min-height: 0;
}
.history-toolbar {
display: flex;
align-items: center;
justify-content: space-between;
gap: 12px;
}
.toolbar-checkbox {
display: inline-flex;
align-items: center;
gap: 10px;
color: var(--text);
font-size: 0.88rem;
}
.toolbar-checkbox.disabled {
opacity: 0.55;
}
.result-strip {
display: flex;
gap: 8px;
overflow: auto;
padding-bottom: 2px;
}
.result-chip {
display: grid;
gap: 4px;
min-width: 220px;
padding: 10px 12px;
border: 1px solid rgba(16, 185, 129, 0.2);
border-radius: 14px;
background: rgba(236, 253, 245, 0.92);
color: #065f46;
font-size: 0.82rem;
}
.result-chip.error {
border-color: rgba(239, 68, 68, 0.18);
background: rgba(254, 242, 242, 0.96);
color: #b42318;
}
.data-table {
display: flex;
flex-direction: column;
height: 100%;
min-height: 0;
border: 1px solid rgba(148, 163, 184, 0.18);
border-radius: 22px;
background: var(--panel);
box-shadow: var(--shadow);
overflow: hidden;
}
.data-table-body {
min-height: 0;
overflow: auto;
scrollbar-gutter: stable;
}
.history-grid {
display: grid;
grid-template-columns: 52px 56px minmax(170px, 1fr) 118px 118px 128px 108px;
gap: 12px;
align-items: center;
}
.data-table-header {
position: sticky;
top: 0;
z-index: 2;
padding: 10px 24px 10px 14px;
border-bottom: 1px solid rgba(148, 163, 184, 0.14);
background: rgba(248, 250, 252, 0.94);
backdrop-filter: blur(12px);
-webkit-backdrop-filter: blur(12px);
}
.data-table-row {
padding: 12px 14px;
border-bottom: 1px solid rgba(148, 163, 184, 0.12);
}
.data-table-row:last-child {
border-bottom: 0;
}
.data-table-row:hover {
background: rgba(248, 250, 252, 0.65);
}
.header-cell {
color: var(--muted);
font-size: 0.81rem;
font-weight: 700;
letter-spacing: 0.02em;
}
.checkbox-cell {
display: flex;
justify-content: center;
}
.icon-cell {
padding-left: 4px;
}
.row-cell {
min-width: 0;
}
.profile-avatar {
display: grid;
place-items: center;
flex-shrink: 0;
background: linear-gradient(135deg, #dbeafe, #eff6ff);
color: #1d4ed8;
font-size: 0.96rem;
font-weight: 700;
overflow: hidden;
}
.table-avatar {
width: 36px;
height: 36px;
border-radius: 999px;
}
.profile-avatar img {
width: 100%;
height: 100%;
object-fit: cover;
}
.primary-cell strong {
display: block;
font-size: 0.93rem;
line-height: 1.3;
}
.subtle-line {
display: block;
margin-top: 3px;
color: var(--muted-soft);
font-size: 0.8rem;
}
.status-pill {
display: inline-flex;
align-items: center;
justify-content: center;
min-width: 78px;
padding: 6px 10px;
border-radius: 999px;
font-size: 0.79rem;
font-weight: 700;
}
.status-pill.found {
background: rgba(37, 99, 235, 0.12);
color: #1d4ed8;
}
.status-pill.missing {
background: rgba(226, 232, 240, 0.7);
color: var(--badge-text);
}
.actions-cell {
display: flex;
justify-content: flex-end;
}
.action-button {
padding-inline: 12px;
}
@media (max-width: 900px) {
.history-grid {
grid-template-columns: 52px 56px minmax(160px, 1fr) 110px 110px 118px 100px;
}
}
@media (max-width: 720px) {
.history-toolbar {
flex-direction: column;
align-items: stretch;
}
.history-grid {
grid-template-columns: 52px 56px minmax(0, 1fr) 108px;
}
.history-grid > :nth-child(5),
.history-grid > :nth-child(6),
.history-grid > :nth-child(7) {
display: none;
}
}
</style>

View File

@@ -1,165 +0,0 @@
<script setup lang="ts">
import type { HistoryDomainSortKey, HistoryDomainSummary } from "../../types/browser";
defineProps<{
historyDomains: HistoryDomainSummary[];
sortKey: HistoryDomainSortKey;
}>();
const emit = defineEmits<{
"update:sortKey": [value: HistoryDomainSortKey];
showProfiles: [domain: string];
}>();
</script>
<template>
<section class="table-section">
<div v-if="historyDomains.length" class="data-table">
<div class="data-table-header history-grid">
<button class="header-cell sortable" :class="{ active: sortKey === 'domain' }" type="button" @click="emit('update:sortKey', 'domain')">Domain</button>
<button class="header-cell sortable" :class="{ active: sortKey === 'visits' }" type="button" @click="emit('update:sortKey', 'visits')">Visits</button>
<div class="header-cell actions-cell">Profiles</div>
</div>
<div class="data-table-body styled-scrollbar">
<article
v-for="historyDomain in historyDomains"
:key="historyDomain.domain"
class="data-table-row history-grid"
>
<div class="row-cell primary-cell">
<strong>{{ historyDomain.domain }}</strong>
</div>
<div class="row-cell muted-cell">{{ historyDomain.visitCount.toLocaleString() }}</div>
<div class="row-cell actions-cell">
<button class="disclosure-button" type="button" @click="emit('showProfiles', historyDomain.domain)">
<span>View</span>
<span class="badge neutral">{{ historyDomain.profileIds.length }}</span>
</button>
</div>
</article>
</div>
</div>
<div v-else class="empty-card">
<p>No browsing history domains were discovered for this browser.</p>
</div>
</section>
</template>
<style scoped>
.table-section {
padding: 0;
height: 100%;
min-height: 0;
}
.data-table {
display: flex;
flex-direction: column;
height: 100%;
min-height: 0;
border: 1px solid rgba(148, 163, 184, 0.18);
border-radius: 22px;
background: var(--panel);
box-shadow: var(--shadow);
overflow: hidden;
}
.data-table-body {
min-height: 0;
overflow: auto;
scrollbar-gutter: stable;
}
.history-grid {
display: grid;
grid-template-columns: minmax(240px, 1.2fr) 140px 154px;
gap: 12px;
align-items: center;
}
.data-table-header {
position: sticky;
top: 0;
z-index: 2;
padding: 10px 24px 10px 14px;
border-bottom: 1px solid rgba(148, 163, 184, 0.14);
background: rgba(248, 250, 252, 0.94);
backdrop-filter: blur(12px);
-webkit-backdrop-filter: blur(12px);
}
.header-cell {
color: var(--muted);
font-size: 0.81rem;
font-weight: 700;
letter-spacing: 0.02em;
}
.header-cell.sortable {
padding: 0;
text-align: left;
background: transparent;
cursor: pointer;
}
.header-cell.sortable.active {
color: var(--text);
}
.data-table-row {
padding: 12px 14px;
border-bottom: 1px solid rgba(148, 163, 184, 0.12);
}
.data-table-row:last-child {
border-bottom: 0;
}
.data-table-row:hover {
background: rgba(248, 250, 252, 0.65);
}
.row-cell {
min-width: 0;
}
.primary-cell strong {
display: block;
font-size: 0.93rem;
line-height: 1.3;
}
.muted-cell {
color: var(--muted);
font-size: 0.87rem;
}
.disclosure-button {
display: flex;
align-items: center;
justify-content: space-between;
gap: 10px;
width: fit-content;
min-width: 120px;
padding: 7px 10px;
border-radius: 12px;
background: rgba(241, 245, 249, 0.9);
color: var(--badge-text);
cursor: pointer;
}
.actions-cell {
display: flex;
justify-content: flex-end;
}
@media (max-width: 720px) {
.history-grid {
grid-template-columns: minmax(0, 1fr) 120px;
}
.history-grid > :nth-child(2) {
display: none;
}
}
</style>

View File

@@ -2,13 +2,7 @@ import { computed, onMounted, ref, watch } from "vue";
import { invoke } from "@tauri-apps/api/core"; import { invoke } from "@tauri-apps/api/core";
import { open } from "@tauri-apps/plugin-dialog"; import { open } from "@tauri-apps/plugin-dialog";
import { import { sortBookmarks, sortExtensions, sortPasswordSites, sortProfiles } from "../utils/sort";
sortBookmarks,
sortExtensions,
sortHistoryDomains,
sortPasswordSites,
sortProfiles,
} from "../utils/sort";
import type { import type {
ActiveSection, ActiveSection,
AppPage, AppPage,
@@ -18,9 +12,10 @@ import type {
BrowserConfigEntry, BrowserConfigEntry,
BrowserConfigListResponse, BrowserConfigListResponse,
BrowserView, BrowserView,
CleanupHistoryInput,
CleanupHistoryResponse,
CreateCustomBrowserConfigInput, CreateCustomBrowserConfigInput,
ExtensionSortKey, ExtensionSortKey,
HistoryDomainSortKey,
PasswordSiteSortKey, PasswordSiteSortKey,
ProfileSortKey, ProfileSortKey,
ScanResponse, ScanResponse,
@@ -56,7 +51,10 @@ export function useBrowserManager() {
const extensionSortKey = ref<ExtensionSortKey>("name"); const extensionSortKey = ref<ExtensionSortKey>("name");
const bookmarkSortKey = ref<BookmarkSortKey>("title"); const bookmarkSortKey = ref<BookmarkSortKey>("title");
const passwordSiteSortKey = ref<PasswordSiteSortKey>("domain"); const passwordSiteSortKey = ref<PasswordSiteSortKey>("domain");
const historyDomainSortKey = ref<HistoryDomainSortKey>("visits"); const cleanupHistorySelectedProfiles = ref<string[]>([]);
const historyCleanupBusy = ref(false);
const cleanupHistoryError = ref("");
const cleanupHistoryResults = ref<CleanupHistoryResponse["results"]>([]);
const browsers = computed(() => response.value.browsers); const browsers = computed(() => response.value.browsers);
const currentBrowser = computed<BrowserView | null>( const currentBrowser = computed<BrowserView | null>(
@@ -78,9 +76,6 @@ export function useBrowserManager() {
const sortedPasswordSites = computed(() => const sortedPasswordSites = computed(() =>
sortPasswordSites(currentBrowser.value?.passwordSites ?? [], passwordSiteSortKey.value), sortPasswordSites(currentBrowser.value?.passwordSites ?? [], passwordSiteSortKey.value),
); );
const sortedHistoryDomains = computed(() =>
sortHistoryDomains(currentBrowser.value?.historyDomains ?? [], historyDomainSortKey.value),
);
watch( watch(
browsers, browsers,
@@ -104,6 +99,9 @@ export function useBrowserManager() {
watch(selectedBrowserId, () => { watch(selectedBrowserId, () => {
openProfileError.value = ""; openProfileError.value = "";
associatedProfilesModal.value = null; associatedProfilesModal.value = null;
cleanupHistorySelectedProfiles.value = [];
cleanupHistoryResults.value = [];
cleanupHistoryError.value = "";
}); });
async function loadBrowserConfigs() { async function loadBrowserConfigs() {
@@ -284,21 +282,13 @@ export function useBrowserManager() {
return name.trim().slice(0, 1).toUpperCase() || "?"; return name.trim().slice(0, 1).toUpperCase() || "?";
} }
function domainFromUrl(url: string) {
try {
return new URL(url).hostname;
} catch {
return url;
}
}
function sectionCount(section: ActiveSection) { function sectionCount(section: ActiveSection) {
if (!currentBrowser.value) return 0; if (!currentBrowser.value) return 0;
if (section === "profiles") return currentBrowser.value.profiles.length; if (section === "profiles") return currentBrowser.value.profiles.length;
if (section === "extensions") return currentBrowser.value.extensions.length; if (section === "extensions") return currentBrowser.value.extensions.length;
if (section === "bookmarks") return currentBrowser.value.bookmarks.length; if (section === "bookmarks") return currentBrowser.value.bookmarks.length;
if (section === "passwords") return currentBrowser.value.passwordSites.length; if (section === "passwords") return currentBrowser.value.passwordSites.length;
return currentBrowser.value.historyDomains.length; return currentBrowser.value.stats.historyCleanupProfileCount;
} }
function showExtensionProfilesModal(extensionId: string) { function showExtensionProfilesModal(extensionId: string) {
@@ -334,17 +324,78 @@ export function useBrowserManager() {
}; };
} }
function showHistoryDomainProfilesModal(domain: string) { function toggleHistoryProfile(profileId: string) {
const historyDomain = currentBrowser.value?.historyDomains.find( if (cleanupHistorySelectedProfiles.value.includes(profileId)) {
(item) => item.domain === domain, cleanupHistorySelectedProfiles.value = cleanupHistorySelectedProfiles.value.filter(
); (selectedId) => selectedId !== profileId,
if (!historyDomain || !currentBrowser.value) return; );
associatedProfilesModal.value = { return;
title: `${historyDomain.domain} Profiles`, }
browserId: currentBrowser.value.browserId,
profiles: historyDomain.profiles, cleanupHistorySelectedProfiles.value = [
isBookmark: false, ...cleanupHistorySelectedProfiles.value,
}; profileId,
];
}
function toggleAllHistoryProfiles() {
const current = currentBrowser.value;
if (!current) return;
const selectableIds = current.profiles
.filter((profile) => {
const cleanup = profile.historyCleanup;
return (
cleanup.history === "found" ||
cleanup.topSites === "found" ||
cleanup.visitedLinks === "found"
);
})
.map((profile) => profile.id);
const allSelected =
selectableIds.length > 0 &&
selectableIds.every((profileId) =>
cleanupHistorySelectedProfiles.value.includes(profileId),
);
cleanupHistorySelectedProfiles.value = allSelected ? [] : selectableIds;
}
async function cleanupHistoryProfiles(profileIds: string[]) {
if (!currentBrowser.value || profileIds.length === 0) return;
historyCleanupBusy.value = true;
cleanupHistoryError.value = "";
cleanupHistoryResults.value = [];
try {
const input: CleanupHistoryInput = {
browserId: currentBrowser.value.browserId,
profileIds,
};
const result = await invoke<CleanupHistoryResponse>("cleanup_history_files", { input });
cleanupHistoryResults.value = result.results;
cleanupHistorySelectedProfiles.value = cleanupHistorySelectedProfiles.value.filter(
(profileId) => !profileIds.includes(profileId),
);
await scanBrowsers();
} catch (cleanupErrorValue) {
cleanupHistoryError.value =
cleanupErrorValue instanceof Error
? cleanupErrorValue.message
: "Failed to clean history files.";
} finally {
historyCleanupBusy.value = false;
}
}
async function cleanupSelectedHistoryProfiles() {
await cleanupHistoryProfiles(cleanupHistorySelectedProfiles.value);
}
async function cleanupHistoryForProfile(profileId: string) {
await cleanupHistoryProfiles([profileId]);
} }
function closeAssociatedProfilesModal() { function closeAssociatedProfilesModal() {
@@ -369,11 +420,15 @@ export function useBrowserManager() {
createCustomBrowserConfig, createCustomBrowserConfig,
currentBrowser, currentBrowser,
deleteCustomBrowserConfig, deleteCustomBrowserConfig,
domainFromUrl,
error, error,
extensionMonogram, extensionMonogram,
extensionSortKey, extensionSortKey,
historyDomainSortKey, cleanupHistoryError,
cleanupHistoryForProfile,
cleanupHistoryResults,
cleanupHistorySelectedProfiles,
cleanupSelectedHistoryProfiles,
historyCleanupBusy,
isDeletingConfig, isDeletingConfig,
isOpeningProfile, isOpeningProfile,
loading, loading,
@@ -390,13 +445,13 @@ export function useBrowserManager() {
selectedBrowserId, selectedBrowserId,
showBookmarkProfilesModal, showBookmarkProfilesModal,
showExtensionProfilesModal, showExtensionProfilesModal,
showHistoryDomainProfilesModal,
showPasswordSiteProfilesModal, showPasswordSiteProfilesModal,
sortedBookmarks, sortedBookmarks,
sortedExtensions, sortedExtensions,
sortedHistoryDomains,
sortedPasswordSites, sortedPasswordSites,
sortedProfiles, sortedProfiles,
toggleAllHistoryProfiles,
toggleHistoryProfile,
closeAssociatedProfilesModal, closeAssociatedProfilesModal,
}; };
} }

View File

@@ -3,7 +3,7 @@ export type BrowserStats = {
extensionCount: number; extensionCount: number;
bookmarkCount: number; bookmarkCount: number;
passwordSiteCount: number; passwordSiteCount: number;
historyDomainCount: number; historyCleanupProfileCount: number;
}; };
export type ProfileSummary = { export type ProfileSummary = {
@@ -16,6 +16,7 @@ export type ProfileSummary = {
defaultAvatarStrokeColor: number | null; defaultAvatarStrokeColor: number | null;
avatarLabel: string; avatarLabel: string;
path: string; path: string;
historyCleanup: HistoryCleanupSummary;
}; };
export type ExtensionSummary = { export type ExtensionSummary = {
@@ -41,11 +42,28 @@ export type PasswordSiteSummary = {
profiles: AssociatedProfileSummary[]; profiles: AssociatedProfileSummary[];
}; };
export type HistoryDomainSummary = { export type HistoryCleanupSummary = {
domain: string; history: CleanupFileStatus;
visitCount: number; topSites: CleanupFileStatus;
visitedLinks: CleanupFileStatus;
};
export type CleanupFileStatus = "found" | "missing";
export type CleanupHistoryInput = {
browserId: string;
profileIds: string[]; profileIds: string[];
profiles: AssociatedProfileSummary[]; };
export type CleanupHistoryResult = {
profileId: string;
deletedFiles: string[];
skippedFiles: string[];
error: string | null;
};
export type CleanupHistoryResponse = {
results: CleanupHistoryResult[];
}; };
export type AssociatedProfileSummary = { export type AssociatedProfileSummary = {
@@ -73,7 +91,6 @@ export type ProfileSortKey = "name" | "email" | "id";
export type ExtensionSortKey = "name" | "id"; export type ExtensionSortKey = "name" | "id";
export type BookmarkSortKey = "title" | "url"; export type BookmarkSortKey = "title" | "url";
export type PasswordSiteSortKey = "domain" | "url"; export type PasswordSiteSortKey = "domain" | "url";
export type HistoryDomainSortKey = "visits" | "domain";
export type AssociatedProfileSortKey = "id" | "name"; export type AssociatedProfileSortKey = "id" | "name";
export type ActiveSection = "profiles" | "extensions" | "bookmarks" | "passwords" | "history"; export type ActiveSection = "profiles" | "extensions" | "bookmarks" | "passwords" | "history";
export type AppPage = "browserData" | "configuration"; export type AppPage = "browserData" | "configuration";
@@ -111,7 +128,6 @@ export type BrowserView = {
extensions: ExtensionSummary[]; extensions: ExtensionSummary[];
bookmarks: BookmarkSummary[]; bookmarks: BookmarkSummary[];
passwordSites: PasswordSiteSummary[]; passwordSites: PasswordSiteSummary[];
historyDomains: HistoryDomainSummary[];
stats: BrowserStats; stats: BrowserStats;
}; };

View File

@@ -3,8 +3,6 @@ import type {
BookmarkSummary, BookmarkSummary,
ExtensionSortKey, ExtensionSortKey,
ExtensionSummary, ExtensionSummary,
HistoryDomainSortKey,
HistoryDomainSummary,
PasswordSiteSortKey, PasswordSiteSortKey,
PasswordSiteSummary, PasswordSiteSummary,
AssociatedProfileSortKey, AssociatedProfileSortKey,
@@ -90,16 +88,6 @@ export function sortPasswordSites(items: PasswordSiteSummary[], sortKey: Passwor
}); });
} }
export function sortHistoryDomains(items: HistoryDomainSummary[], sortKey: HistoryDomainSortKey) {
const historyDomains = [...items];
return historyDomains.sort((left, right) => {
if (sortKey === "domain") {
return compareOptionalText(left.domain, right.domain) || right.visitCount - left.visitCount;
}
return right.visitCount - left.visitCount || compareOptionalText(left.domain, right.domain);
});
}
export function sortAssociatedProfiles( export function sortAssociatedProfiles(
items: (AssociatedProfileSummary | BookmarkAssociatedProfileSummary)[], items: (AssociatedProfileSummary | BookmarkAssociatedProfileSummary)[],
sortKey: AssociatedProfileSortKey, sortKey: AssociatedProfileSortKey,